Feature edit request body in editor #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jootd
changed the title
|
Hi, can you please add the GPL copyright notice to the top of any new files that you create? (Same request for your other PR #16) Could you also please rebase this onto the latest master from my branch? Thanks |
|
Ofc , I will asap |
mfinelli
requested changes
Oct 31, 2022
|
So, I need to merge master into this branch and commit ,am I right ? |
|
It would be better if you rebased on top of master. But if you merge then I think I can still clean it up before I merge to master. |
Done, but I'm not sure that I did it right way 😌 |
mfinelli
approved these changes
Nov 2, 2022
|
Squashed and merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine . with vim and neovim ( on my machine :) )
Resolves #9