Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling computation #72

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Jul 21, 2023

  • Fixes division-by-zero case when computing scrolling hvalue and vvalue. This happens when the viewport and content pane sizes (doubles) are exactly equal. This seems to happen frequently in Ubuntu (22).
  • Note: Testfx does not seem to allow reproducing the issue via tests.

Fixes #70 .

@mfl28 mfl28 self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.03 ⚠️

Comparison is base (2d46fda) 85.75% compared to head (d310c0c) 85.72%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
- Coverage     85.75%   85.72%   -0.03%     
- Complexity     1409     1410       +1     
============================================
  Files            92       92              
  Lines          5763     5767       +4     
  Branches        522      524       +2     
============================================
+ Hits           4942     4944       +2     
- Misses          562      563       +1     
- Partials        259      260       +1     
Impacted Files Coverage Δ
...fl28/boundingboxeditor/ui/EditorImagePaneView.java 85.43% <75.00%> (-0.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 088bc08 into master Jul 21, 2023
10 checks passed
@mfl28 mfl28 deleted the bugfix/fix-scrolling-and-panning-on-ubuntu branch July 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panning and scrolling does not work correctly (on Ubuntu)
1 participant