Ensure HAVE_CXX11 is checked when defining TINS_IS_CXX11 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include config.h in macros.h? Otherwise you need to have included config.h for this macro to work correctly. |
|
Yes, you're right! Didn't realize that before. Also, using 'defined(x)' isn't supposed to work elsewhere than in an 'if' preprocessor directive, so I updated the previous change (also prevents C4668 in VS2013). |
|
Another commit to make sure TINS_IS_CX11 can't be redefined. |
|
Sorry, I thought the CXX11 definitions were in macros.h. So the config.h include line should be in cxxstd.h rather than in macros.h. |
Include config.h in cxxstd.h
|
Done. |
|
Seems good, thanks! |
mfontanini
added a commit
that referenced
this pull request
Apr 6, 2015
Ensure HAVE_CXX11 is checked when defining TINS_IS_CXX11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I fixed #64, enabling compilation on VS2013 when configuring with LIBTINS_ENABLE_CXX11=0 defined. Still seems like a good idea to check this macro here, even with 3478c7b.