feat: improve pa11y typings #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af-owe
approved these changes
May 2, 2024
|
@mfrachet Can you merge this PR, so we have proper typings for pa11y? |
|
Hey, I forked the package, fixed the typings, allowed selecting the html element with errors in pa11y and updated pa11y and lighthouse. Also extended the README, replaced the examples and published to NPM. It is now only one package for both pa11y and lighthouse. I did not want to manage multiple npm packages. But it should be explained here: https://github.com/appsfactorygmbh/cypress-audit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as #186 for pa11y