Explained Variation Metric #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
+ Coverage 97.97% 98% +0.02%
=======================================
Files 5 5
Lines 99 100 +1
=======================================
+ Hits 97 98 +1
Misses 2 2
Continue to review full report at Codecov.
|
mfrasco
approved these changes
Oct 18, 2018
| @@ -337,3 +337,24 @@ rrse <- function(actual, predicted) { | |||
| rae <- function(actual, predicted) { | |||
| return(sum(ae(predicted, actual)) / sum(ae(actual, mean(actual)))) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Thanks so much for contributing to the package. I really appreciate it! Also, thanks a lot for adding tests and following the design patterns set by the package. That's awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing and maintaining this project! I've been using it in some of my work, and thought I'd contribute a simple calculation of explained variance (a.k.a coefficient of determination) I've wrote on top of it. I've taken a first pass at writing, documenting, and testing the code. Happy to make any changes, or to close this PR if it's not worth the time.
This PR also bumps up the Roxygen version from 6.0.1 to 6.1.0.