Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSyntaxTextArea to version 2.5.8 #392

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

iMichka
Copy link
Contributor

@iMichka iMichka commented Jun 10, 2016

The .jar file is coming from here:
http://search.maven.org/#search%7Cga%7C1%7Crsyntaxtextarea%20jar
You may double check the md5 sum.

Also, I saw that you are adding maven support. I do not know if you plan to build the weblaf-complete target through maven, but this may be a good thing so you can remove the .jars from the lib folder and let maven download them for you.

@mgarin
Copy link
Owner

mgarin commented Jun 10, 2016

Thanks for the update, I will merge this slightly later since some more ANT build and property file changes are probably required.

Also, I saw that you are adding maven support. I do not know if you plan to build the weblaf-complete target through maven, but this may be a good thing so you can remove the .jars from the lib folder and let maven download them for you.

Only core, ui and demo module artifacts will be released to maven. I don't think it's a good idea to upload complete artifact there as it kind of goes against maven ideology. I will simply upload complete artifact with releases - to the site and GitHub, and snapshot updates - to the site only.

If you are using maven you don't need complete artifact anyway, simply use the weblaf-ui one which will be sufficient to build an application or weblaf-core if you only need some base features offerred by the library.

Later on there will be more modules within the library and each separate module will also have its own artifact - you can read my thoughts/plans about that in issue #336

@mgarin mgarin added this to the v1.2.9 milestone Jun 10, 2016
@mgarin mgarin self-assigned this Jun 10, 2016
@iMichka
Copy link
Contributor Author

iMichka commented Jun 14, 2016

Thanks. You are right, pushing the weblaf-complete artifact to maven does not make sense.

I will use the weblaf-ui artifact. I previously used the weblaf-complete artifact because it was faster to implement in our home-made build/release system, as the dependencies were already delivered with it. But this has proven problematic lately.

@mgarin mgarin merged commit b3b084d into mgarin:styling Jun 14, 2016
@mgarin
Copy link
Owner

mgarin commented Jun 14, 2016

it was faster to implement in our home-made build/release system, as the dependencies were already delivered with it

Before WebLaF was released into Maven that was certainly true, however now all dependencies are also delivered with weblaf-ui dependency so it should also work for you if you are using Maven :)

I have merged the updated library, thanks again!

@mgarin
Copy link
Owner

mgarin commented Jun 14, 2016

I have also pushed updated sources - rsyntaxtextarea-2.5.8-sources.jar

@iMichka iMichka deleted the RSyntaxTextArea branch January 26, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants