Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russia main.cpp holes_inside_polygons() bug #32

Closed
fillingthemoon opened this issue Jun 29, 2021 · 1 comment
Closed

Russia main.cpp holes_inside_polygons() bug #32

fillingthemoon opened this issue Jun 29, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@fillingthemoon
Copy link
Collaborator

I came across a bug on the master branch.

To reproduce this bug, please follow these steps:

  1. git checkout master

  2. Place the attached russia.geojson (after unzipping) and inset_russia_population.csv into the sample_data/inset_data/ directory.
    inset_russia_modified_population.csv
    russia.geojson.zip

  3. Run the following in your terminal.

cd build/
cmake .
make
./cartogram -g ../sample_data/inset_data/russia.geojson -v ../sample_data/inset_data/inset_russia_population.csv
  1. Issue: It prints a bunch of coordinates to the output (screenshot below) and does not produce any GeoJSONs. When I comment out lines 190-201 in main.cpp, however, it runs fine. It seems then that this Russia example is getting stuck in holes_inside_polygons().

Screenshot 2021-06-29 at 12 54 32 PM

@mgastner
Copy link
Owner

Exterior ring and hole shared a common vertex. Updated versions of the C++ code do not treat this as a topology error any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants