Combine TestRunner, TestManager and TestScheduler and other cleanup #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The INITIALIZED state for subprocess was not being used and was not important for running, so the state has been removed.
It didn't make sense having the above classes separated and as nested-subclasses, in fact, it just made things more complicated as each one was needed to be passed to another. This commit combines them all into the TestRunner (to be renamed the TestManager).
As well rename the class TestRunner to be TestManager
The ResultProxy contained elements that weren't needed, so this commit removes them. It also adds documentation and explanation of the ResultClass, ResultProxy and result manager.
env.get_modset was a duplicate of env.list_modset, so env.get_modset was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits contain a number of changes. The biggest of which combines TestRunner, TestManager and TestScheduler in testRunner.py, which has now been renamed to testManager.py.
Other changes include: