Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when analyzing packages without go.mod #1027

Closed
chavacava opened this issue Aug 18, 2024 · 1 comment · Fixed by #1028
Closed

Error when analyzing packages without go.mod #1027

chavacava opened this issue Aug 18, 2024 · 1 comment · Fixed by #1028
Assignees
@chavacava

Comments

@chavacava
Copy link
Collaborator

if the package under analysis hasn't a go.mod file, revive stops with the error

linting - retrieving failures channel: "<package full path>" doesn't seem to be part of a Go module

To Reproduce
Steps to reproduce the behavior:

  1. I updated revive go install github.com/mgechev/revive@latest
  2. Check out vim-go
  3. Remove or rename the file vim-go/autoload/go/test-fixtures/lint/src/errcheck/go.mod
  4. From the go-vimI directory, run revive:
revive ./...

Expected behavior
revive should analyze the go sources without reporting the above error
@chavacava chavacava mentioned this issue Aug 18, 2024
Closed
@chavacava chavacava self-assigned this Aug 18, 2024
@chavacava chavacava mentioned this issue Aug 18, 2024
Merged
@chavacava
Copy link
Collaborator Author

chavacava commented Aug 18, 2024 •
edited
Loading

@bhcleek could you please confirm that the PR #1028 fixes the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chavacava chavacava

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use a default Go version (1.0) in absence of go.mod mgechev/revive
1 participant
@chavacava