Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: false positive in import-shadowing for method names #876

Merged
merged 3 commits into from
Aug 21, 2023
Merged

fix: false positive in import-shadowing for method names #876

merged 3 commits into from
Aug 21, 2023

Conversation

denisvmedia
Copy link
Collaborator

Closes #875

@denisvmedia denisvmedia mentioned this pull request Aug 21, 2023
Closed
denisvmedia
denisvmedia commented Aug 21, 2023
View reviewed changes
rule/import-shadowing.go Outdated Show resolved Hide resolved
@chavacava chavacava merged commit 4ee7542 into mgechev:master Aug 21, 2023
4 checks passed
@denisvmedia denisvmedia deleted the import-shadowing-ignore-methods branch August 22, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import-shadowing reacts on method names while it shouldn't
2 participants
@denisvmedia @chavacava