Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup rules functions declarations #952

Closed
wants to merge 3 commits into from
Closed

cleanup rules functions declarations #952

wants to merge 3 commits into from

Conversation

mfederowicz
Copy link
Contributor

cleanup rules functions declarations (add variable name next to struct name)

denisvmedia
denisvmedia reviewed Dec 24, 2023
View reviewed changes
rule/add-constant.go Outdated Show resolved Hide resolved
@mfederowicz mfederowicz force-pushed the cleanup-rules-functions-declarations branch 2 times, most recently from c01f551 to 577f932 Compare December 25, 2023 00:51
@mfederowicz mfederowicz force-pushed the cleanup-rules-functions-declarations branch from 577f932 to 3db9ce1 Compare December 25, 2023 00:52
@mfederowicz
Copy link
Contributor Author

sorry @denisvmedia for that PR but I thought that all rules files should have consistent Receiver Prefix/Suffix naming convention, but after reading all rules files I made decision to close this PR becase maybe not all rules function have the same Receiver Prefix but all of them have some (of course only if they are used).

@mfederowicz mfederowicz deleted the cleanup-rules-functions-declarations branch October 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisvmedia denisvmedia denisvmedia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfederowicz @denisvmedia