Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 11 compatibility #309

Merged
merged 31 commits into from
Aug 14, 2024
Merged

Drupal 11 compatibility #309

merged 31 commits into from
Aug 14, 2024

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Aug 12, 2024

D11 uses Symfony 7.0. Update the Symfony version constraint to also allow version 7.0 and higher.

Also

  • Fixes an issue on CircleCI where it was trying to install a version of CTools that does not support D8.
  • Fixes an issue on AppVeyor where Composer project creation was failing due to plugins not being allowed.

@mglaman
Copy link
Owner

mglaman commented Aug 13, 2024

Wow, thanks! If this is ready I can merge

@byrond
Copy link
Contributor Author

byrond commented Aug 13, 2024

I believe it finally is! :)

Is this script still useful on D9+ sites? (At a minimum, it fixes some of the CI issues.)

@mglaman
Copy link
Owner

mglaman commented Aug 13, 2024

I've been recommending folks use PHPStan directly, especially since adding drupal/core-dev sets up basic configuration

@byrond
Copy link
Contributor Author

byrond commented Aug 13, 2024

If this won't need to be installed on D11, feel free to pull out the Symfony version constraint updates. We can look into just using PHPStan directly and remove it from our build tool-chain for the D11 update.

@mglaman
Copy link
Owner

mglaman commented Aug 13, 2024

Oh, I think others still use this and your PR is valuable.

In my FLDC talk I explained how to use PHPStan directly: http://2024.fldrupal.camp/sites/default/files/2024-02/Tighten%20up%20your%20Drupal%20code%20using%20PHPStan%20-%20FLDC%202024/index.pdf

@mglaman mglaman merged commit 4011f1f into mglaman:main Aug 14, 2024
18 checks passed
@byrond byrond deleted the patch-2 branch September 6, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants