Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to load in repository configuration #2

Closed
daurnimator opened this issue Jun 29, 2020 · 2 comments
Closed

Method to load in repository configuration #2

daurnimator opened this issue Jun 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@daurnimator
Copy link

I saw a TODO to allow loading in repository config at https://github.com/mgoltzsche/helm-kustomize-plugin/blob/b891cf188f8b1c74acf68aa6aa4141811ccde5e4/pkg/helm/helm.go#L72

For my particular case, I'd like to run from ArgoCD, which has repositories configured in it: I should be able to point helm-kustomize-plugin at them somehow.

@mgoltzsche
Copy link
Owner

@daurnimator thanks for reporting that issue! I totally agree that this todo there should be resolved.
Some time ago I already wondered if I shouldn't have used the helm binary instead of compiling it into the plugin binary. That could have solved this issue as well.

However currently I don't have time to look into this unfortunately.
Though would you like to create PR?

@mgoltzsche
Copy link
Owner

@daurnimator now the repository credentials are picked up from the configuration in helm home (if helm's repositories.yaml has an entry with an URL that matches the chart's repository URL its auth configuration is used to load the chart).
Therefore helm repository credentials can be managed as usual using helm repo add.

mgoltzsche added a commit that referenced this issue Oct 25, 2020
Also fixes and enables the repo credential test.
Relates to #2
@mgoltzsche mgoltzsche added the enhancement New feature or request label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants