Add lockFile support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this only works when the chart is already unpacked. I'm working on a fix. |
|
It seems like this PR isn't getting updated when I push changes to my branch. I'm going to close it and create another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #1.
If a
ChartRendererspec contains alockFilekey pointing to arequirements.lockfile (the source filename doesn't matter), it will be copied to the unpacked chart asrequirements.lock.LoadChartnow delegates most of its work to Helm's download manager'sBuild()method, which includes logic to checkrequirements.lockvalidity.Let me know if there's anything else I can do to help get this landed!