Add support for InputObjects and Objects as args #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wokalski
commented
Sep 16, 2017
•
wokalski
commented
- fix infinite recursion in recursive objects
- add support for lists
- properly report errors
- use rec flag only if needed
wokalski
changed the title
wokalski
changed the title
Objects can have bidirectional relationships. Therefore their relationship cannot be expressed using a acyclic graph and therefore we cannot create the encoders inline because it causes infinite recursion. I.e. if User has a relationship to User the depth of users can be infinitely big. That's why separate encoders are introduced. They are defined according to the following scheme: json_of_TYPE where TYPE is type name from the schema This commit screws up error locations though, but it will be fixed in the following commits.
wokalski
changed the title
|
@mhallin this is ready for review. I'll be using it from now on to see if there are some new bugs so you might want to wait with public release. If I don't discover any bugs in the next two days I'll let you know. |
|
There were no issues so far for me. Good to merge IMO! |
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.