Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeGW improvements #2180

Merged
merged 4 commits into from
Feb 20, 2024
Merged

MakeGW improvements #2180

merged 4 commits into from
Feb 20, 2024

Conversation

CristiFati
Copy link
Contributor

@CristiFati CristiFati commented Feb 17, 2024

This is just side work as I was trying to add IFolderView functionality (to properly answer to [SO]: How to move desktop icons with python?) to win32comext.shell, and the process is annoying (well, since the 2nd time I was running it from command line via -c, but having proper argument handling is the way to go).

As I was saying I was trying to add IFolderView, but the file no longer parses modern headers (tried ShObjIdl_core.h), due to __RPC__* specifiers (from rpcsal.h). It generates the files, but they don't compile due to (wrongly interpreting argument types - at least this is what I've seen so far).

I have some more changes (not included here) to the same file (basically getting rid of those specifiers), but the output files still need manual intervention (didn't reach (yet) a point where the file compiles (and works)).
Given the headache involved, I'm thinking I'm on the wrong path as there were no (significant) changes on the file file for a long long time, could it be a simpler variant?

As I also mentioned there, this is a side quest for #2181.

Last 2 commits made my life much easier, but there's still some work to be done, so that it works in an automated manner.

Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, thanks! I don't think this has generated code which compiled without modification for well over a decade!

@mhammond mhammond merged commit 07f984d into mhammond:main Feb 20, 2024
16 checks passed
@CristiFati CristiFati deleted the cfati_dev00 branch March 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants