Stop using printf
-style string formatting for direct string interpolation (%s
)
#2277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2122
Ran using
ruff check --fix --unsafe-fixes --select=UP031 --exclude=adodbapi
thenruff format
This replaces all usages of exclusively
%s
for string formatting with newer style.format
introduced in Python 2.6 .This autofix is considered "unsafe" when Ruff cannot statically establish that the following case is always false:
Due to the sheer amount o changes (359) this is kept to automated changes only.
%d
and%r
will be done in separate PRs as they're not handled byUP031
.Preferring f-strings will come as a follow-up since that can make the line go over the 100 chars limit.
References:
https://docs.astral.sh/ruff/rules/printf-string-formatting/#why-is-this-bad
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting