Skip to content
This repository has been archived by the owner on Jan 15, 2023. It is now read-only.

Add: working incompatibility fix #141

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Add: working incompatibility fix #141

merged 2 commits into from
Jun 5, 2019

Conversation

dalisoft
Copy link
Contributor

@dalisoft dalisoft commented Jun 5, 2019

Related issue: #140, here or here

@mhart
Copy link
Owner

mhart commented Jun 5, 2019

Oh wow – that seems like a pretty extreme solution – I'd be worried a lot of system software might break with this change?

@dalisoft
Copy link
Contributor Author

dalisoft commented Jun 5, 2019

No, it just adds missing file. That's all, i checked a lot of times. Also spent almost 20 hour to find fix for this :)

@mhart
Copy link
Owner

mhart commented Jun 5, 2019

Ohhh, I see – sorry, didn't look at what you were doing correctly, I thought you were overriding the musl library with a softlink to libc – instead of the other way around 😄

@dalisoft
Copy link
Contributor Author

dalisoft commented Jun 5, 2019

No prob, thanks for amazing small Docker Node.js image, works very fast and best

README.md Outdated Show resolved Hide resolved
@mhart
Copy link
Owner

mhart commented Jun 5, 2019

Thanks so much! Merging 👍

@mhart mhart merged commit 69a1e7a into mhart:master Jun 5, 2019
@dalisoft dalisoft deleted the patch-1 branch June 5, 2019 18:21
@dalisoft
Copy link
Contributor Author

dalisoft commented Jun 5, 2019

Thank you for merge =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants