Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

Vim 8 Support #84

Closed
wants to merge 4 commits into from
Closed

Vim 8 Support #84

wants to merge 4 commits into from

Conversation

roxma
Copy link
Contributor

@roxma roxma commented Oct 14, 2017

It's totally fine to close or lock this PR if you're not interested.

I'm writing this PR as a demo for vim 8 support via nvim-yarp and vim-hug-neovim-rpc

It works on my side, but I haven't done full testing. And I don't intend to do so.

It's just a proof of concept.

No need to modify existing code. Just a few lines to set the command and function bindings

ts

roxma added a commit to roxma/nvim-yarp that referenced this pull request Oct 14, 2017
@mhartington
Copy link
Owner

Awesome! Mind rebase the commit and I can merge?

@roxma
Copy link
Contributor Author

roxma commented Oct 17, 2017

I've rebased the code.

But it's not fully tested. vim-hug-neovim-rpc is still marked as experimental.

And I have no plan for testing, as I'm not a typescript developer.

@mhartington
Copy link
Owner

Thanks for the PR @roxma , I'll spend some time testing and see if I can provide feedback on the rpc plugin!

@harg
Copy link

harg commented Nov 8, 2017

@mhartington, are you planning to support Vim 8?

@mhartington
Copy link
Owner

I do plan on merging this, for sure.
Just busy at the moment! Sorry for the delay

@harg
Copy link

harg commented Nov 8, 2017

Don't be sorry, i just wanted to know :) Thank you for your work on this!

@mhartington
Copy link
Owner

Hey @roxma Im ready to merge this, but in testing I'm getting this error on startup

$ vim main.ts
Vim: Caught deadly signal ABRT
Vim: Finished.
zsh: abort      vim main.ts

Not 100% where the error is being caused. Seems as soon as I call TSStart, it errors. Any ideas

@mhartington mhartington mentioned this pull request Nov 26, 2017
@joereynolds
Copy link

ping @roxma

@jason076
Copy link

jason076 commented Apr 27, 2018

@roxma Are you going to continue your work on that topic or is the vim8 support canceled? I hope you will further develop vim-hug-neovim-rpc. Just downloaded the two wrapper files for nvim-typescript yesterday and it works great. Go on with that!

@mhartington
Copy link
Owner

Hey folks, no need to ping roxma.
I'll pick this back up next week.
I've been super busy with work, and have a few open issues I need to take care of first.

@igor-ribeiro
Copy link

Hey @mhartington! Any updates? Thanks

@mhartington
Copy link
Owner

Since I moved to node, this PR was no longer needed.

I do not use Vim8 anymore. If someone is willing to provide a PR, I'll accept it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants