-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
Awesome! Mind rebase the commit and I can merge? |
I've rebased the code. But it's not fully tested. vim-hug-neovim-rpc is still marked as experimental. And I have no plan for testing, as I'm not a typescript developer. |
Thanks for the PR @roxma , I'll spend some time testing and see if I can provide feedback on the rpc plugin! |
@mhartington, are you planning to support Vim 8? |
I do plan on merging this, for sure. |
Don't be sorry, i just wanted to know :) Thank you for your work on this! |
Hey @roxma Im ready to merge this, but in testing I'm getting this error on startup
Not 100% where the error is being caused. Seems as soon as I call |
ping @roxma |
@roxma Are you going to continue your work on that topic or is the vim8 support canceled? I hope you will further develop vim-hug-neovim-rpc. Just downloaded the two wrapper files for nvim-typescript yesterday and it works great. Go on with that! |
Hey folks, no need to ping roxma. |
Hey @mhartington! Any updates? Thanks |
Since I moved to node, this PR was no longer needed. I do not use Vim8 anymore. If someone is willing to provide a PR, I'll accept it. |
It's totally fine to close or lock this PR if you're not interested.
I'm writing this PR as a demo for vim 8 support via nvim-yarp and vim-hug-neovim-rpc
It works on my side, but I haven't done full testing. And I don't intend to do so.
It's just a proof of concept.
No need to modify existing code. Just a few lines to set the command and function bindings