Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Text Selection Mechanics #18

Closed
mhbeals opened this issue Oct 15, 2019 · 0 comments
Closed

Improve Text Selection Mechanics #18

mhbeals opened this issue Oct 15, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mhbeals
Copy link
Owner

mhbeals commented Oct 15, 2019

Current text selection mechanic is fiddly.

Last Word Error:

  • Fixed "last word" bug where the counter goes to -1 when finding a selection including the last word of the item (Fixed 0.3.8)

Repeated Text Error:

Sometimes a selection of text might appear multiple times in an item. Currently the heuristic just looks for the first instance of the phrase. To make this more robust, we need to have a better indexing system:

  • Change find exact word in location
  • Count spaces before exact word for start word number
  • Count spaces in text selection for end word number
@mhbeals mhbeals added the bug Something isn't working label Oct 15, 2019
@mhbeals mhbeals self-assigned this Oct 15, 2019
mhbeals added a commit that referenced this issue Oct 15, 2019
@mhbeals mhbeals closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants