Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: The main property of .../eslint-config/package.json must be index.js #22

Closed
mheob opened this issue Aug 26, 2022 · 0 comments · Fixed by #23
Closed

[BUG]: The main property of .../eslint-config/package.json must be index.js #22

mheob opened this issue Aug 26, 2022 · 0 comments · Fixed by #23
Assignees
@mheob
Labels
bug Something isn't working eslint Belongs to ESLint config

Comments

@mheob
Copy link
Owner

mheob commented Aug 26, 2022

Description of the bug

In our last change (#19) we forgot to change the main attribute from index.cjs to index.js.

Steps To Reproduce

See

config/packages/eslint-config/package.json

Line 17 in 6e97fe2

"main": "index.cjs",

Additional Information

No response
@mheob mheob added bug Something isn't working eslint Belongs to ESLint config labels Aug 26, 2022
mheob added a commit that referenced this issue Aug 26, 2022
@mheob
fix(eslint): use correct index.js
21b3602 
Resolves #22
@mheob mheob mentioned this issue Aug 26, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #23 Aug 26, 2022
kodiakhq bot pushed a commit that referenced this issue Aug 26, 2022
@mheob
fix(eslint): use correct index.js (#23)
7c1d265 
Resolves #22

## 📑 Description

Change old and wrong `main` file name in `package.json` from `index.cjs` to `index.js`.
@mheob mheob self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mheob mheob

Labels
bug Something isn't working eslint Belongs to ESLint config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint): use correct index.js mheob/config
1 participant
@mheob