feat(prettier)!: remove sort import #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Sorting/moving imports, object keys, class members, JSX keys, CSS properties or anything else..." should not be part of `prettier`. See: https://prettier.io/docs/en/rationale.html#what-prettier-is-_not_-concerned-about BREAKING CHANGE: Prettier will no more sort the imports. Use the `@mheob/eslint-config` for this behavior.
mheob
added
enhancement
🦋 Changeset detectedLatest commit: a08ab25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Kudos, SonarCloud Quality Gate passed!
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @mheob/eslint-config@4.0.0 ### Major Changes - add `eslint-plugin-simple-import-sort` and `eslint-plugin-import` ESLint plugins --> ([#103](#103)) by [@mheob](https://github.com/mheob) ### Minor Changes - add newest rules from `eslint-plugin-unicorn` --> ([#101](#101)) by [@mheob](https://github.com/mheob) ### Patch Changes - chore(deps): update all non-major dependencies --> ([#99](#99)) by [@renovate](https://github.com/apps/renovate) - chore(deps): update all non-major dependencies --> ([#95](#95)) by [@renovate](https://github.com/apps/renovate) ## @mheob/prettier-config@3.0.0 ### Major Changes - remove `@trivago/prettier-plugin-sort-imports` --> ([#102](#102)) by [@mheob](https://github.com/mheob) ### Patch Changes - chore(deps): update all non-major dependencies --> ([#95](#95)) by [@renovate](https://github.com/apps/renovate) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
May 23, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @mheob/eslint-config@6.0.0 # @mheob/eslint-config ## 5.2.0 ### Minor Changes - [#147](#147) ([@mheob](https://github.com/mheob)): set `unicorn/no-null` rule to `off` ## 5.1.1 ### Patch Changes - [#145](#145) ([@mheob](https://github.com/mheob)): update dependencies - [#135](#135) ([@mheob](https://github.com/mheob)): update dependencies ## 5.1.0 ### Minor Changes - [#131](#131) ([@mheob](https://github.com/mheob)): add `cts` and `mts` file extensions to the eslint config ### Patch Changes - [#133](#133) ([@mheob](https://github.com/mheob)): update dependencies - [#129](#129) ([@renovate](https://github.com/apps/renovate)): chore(deps): update all non-major dependencies ## 5.0.1 ### Patch Changes - [#125](#125) ([@renovate](https://github.com/apps/renovate)): chore(deps): update all non-major dependencies ## 5.0.0 ### Major Changes - [#124](#124) ([@mheob](https://github.com/mheob)): Bump `eslint-plugin-unicorn` to v47. BREAKING CHANGE: Enable `prefer-at`, `prefer-event-target`, and `prefer-string-replace-all` in recommended config (see [#2073](sindresorhus/eslint-plugin-unicorn#2073)) ### Patch Changes - [#122](#122) ([@renovate](https://github.com/apps/renovate)): chore(deps): update all non-major dependencies ## 4.2.1 ### Patch Changes - update dependencies --> ([#121](#121)) by [@mheob](https://github.com/mheob) ## 4.2.0 ### Minor Changes - remove explicit return rule --> ([#113](#113)) by [@mheob](https://github.com/mheob) - move `explicit-function-return-type` rule to base config --> ([#116](#116)) by [@mheob](https://github.com/mheob) ### Patch Changes - update dependencies --> ([#112](#112)) by [@mheob](https://github.com/mheob) - fix the README files after the change of using ESLint to fix the imports --> ([#109](#109)) by [@mheob](https://github.com/mheob) ## 4.1.0 ### Minor Changes - add auto-fix for unused imports and vars --> ([#106](#106)) by [@mheob](https://github.com/mheob) ### Patch Changes - bump `eslint-config-next` to `13.1.0` --> ([#106](#106)) by [@mheob](https://github.com/mheob) ## 4.0.0 ### Major Changes - add `eslint-plugin-simple-import-sort` and `eslint-plugin-import` ESLint plugins --> ([#103](#103)) by [@mheob](https://github.com/mheob) ### Minor Changes - add newest rules from `eslint-plugin-unicorn` --> ([#101](#101)) by [@mheob](https://github.com/mheob) ### Patch Changes - chore(deps): update all non-major dependencies --> ([#99](#99)) by [@renovate](https://github.com/apps/renovate) - chore(deps): update all non-major dependencies --> ([#95](#95)) by [@renovate](https://github.com/apps/renovate) ## 3.1.0 ### Minor Changes - disable `unicorn/no-array-reduce` ESLint rule --> ([#93](#93)) by [@mheob](https://github.com/mheob) ### Patch Changes - bump eslint to ^8.27.0 --> ([#91](#91)) by [@renovate](https://github.com/apps/renovate) - bump `@typescript-eslint` monorepo --> ([#89](#89)) by [@mheob](https://github.com/mheob) ## 3.0.1 ### Patch Changes - Update dependencies --> ([#77](#77)) by [@mheob](https://github.com/mheob) - update dependencies --> ([#81](#81)) by [@mheob](https://github.com/mheob) - update dependencies --> ([#86](#86)) by [@mheob](https://github.com/mheob) - update dependencies --> ([#84](#84)) by [@renovate](https://github.com/apps/renovate) ## 3.0.0 ### Major Changes - [#72](#72) [`6c13a4f`](6c13a4f) Thanks [@mheob](https://github.com/mheob)! - Update dependencies and use the new rules from `eslint-plugin-unicorn`, especially [switch-case-braces](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/switch-case-braces.md) ## 2.2.0 ### Minor Changes - [#59](#59) [`ec5e9e3`](ec5e9e3) Thanks [@mheob](https://github.com/mheob)! - Disable `unicorn/no-array-for-each` rule as default ### Patch Changes - [#60](#60) [`12b3867`](12b3867) Thanks [@mheob](https://github.com/mheob)! - Update dependencies ## 2.1.2 ### Patch Changes - [#53](#53) [`f7b87f4`](f7b87f4) Thanks [@mheob](https://github.com/mheob)! - Simpplify and fix calling sub configurations ## 2.1.1 ### Patch Changes - [#49](#49) [`348d277`](348d277) Thanks [@mheob](https://github.com/mheob)! - Update dependencies - [#46](#46) [`6f731ee`](6f731ee) Thanks [@mheob](https://github.com/mheob)! - Switch to typescript as source files - [#42](#42) [`cf8ba94`](cf8ba94) Thanks [@mheob](https://github.com/mheob)! - Format all files to the new tabs instead of spaces behaviour - [#36](#36) [`fd1474e`](fd1474e) Thanks [@mheob](https://github.com/mheob)! - Update dependencies ## 2.1.0 ### Minor Changes - 718c5e2: Deactivate `@typescript-eslint/explicit-function-return-type` rule for jsx files. - 70cbb2c: Add typescript definitions ### Patch Changes - 8a868bf: Update dependencies ## 2.0.2 ### Patch Changes - 87fb7e0: Update all dependencies - a211713: Add more typescript specific rules. ## 2.0.1 ### Patch Changes - 7c1d265: Change old and wrong `main` file name in `package.json` from `index.cjs` to `index.js`. ## 2.0.0 ### Major Changes - 6e97fe2: Split ESLint configuration into specified files (base/reat/next for now). ### Patch Changes - 6e97fe2: Improve README to get a better copy/paste experience. ## 1.0.1 ### Patch Changes - 7d96f86: Update all dependencies ## 1.0.0 ### Major Changes - 723ce7d: Initial configuration ## @mheob/prettier-config@3.2.1 # @mheob/prettier-config ## 3.2.0 ### Minor Changes - [#149](#149) ([@mheob](https://github.com/mheob)): remove line wraps in markdown files ## 3.1.1 ### Patch Changes - [#145](#145) ([@mheob](https://github.com/mheob)): update dependencies ## 3.1.0 ### Minor Changes - [#133](#133) ([@mheob](https://github.com/mheob)): bump prettier to version 3 ## 3.0.1 ### Patch Changes - fix the README files after the change of using ESLint to fix the imports --> ([#109](#109)) by [@mheob](https://github.com/mheob) ## 3.0.0 ### Major Changes - remove `@trivago/prettier-plugin-sort-imports` --> ([#102](#102)) by [@mheob](https://github.com/mheob) ### Patch Changes - chore(deps): update all non-major dependencies --> ([#95](#95)) by [@renovate](https://github.com/apps/renovate) ## 2.0.3 ### Patch Changes - update dependencies --> ([#81](#81)) by [@mheob](https://github.com/mheob) - update dependencies --> ([#86](#86)) by [@mheob](https://github.com/mheob) - update dependencies --> ([#84](#84)) by [@renovate](https://github.com/apps/renovate) ## 2.0.2 ### Patch Changes - [#71](#71) [`b79f37d`](b79f37d) Thanks [@mheob](https://github.com/mheob)! - Remove obsolete `prettier-plugin-jsdoc` package ## 2.0.1 ### Patch Changes - [#63](#63) [`49204ca`](49204ca) Thanks [@mheob](https://github.com/mheob)! - Add the newest ruleset to the README - [#60](#60) [`12b3867`](12b3867) Thanks [@mheob](https://github.com/mheob)! - Update dependencies ## 2.0.0 ### Major Changes - [#42](#42) [`cf8ba94`](cf8ba94) Thanks [@mheob](https://github.com/mheob)! - Switch from spaces to tabs as indentation ### Minor Changes - [#52](#52) [`8bc72cd`](8bc72cd) Thanks [@mheob](https://github.com/mheob)! - Use spaces instead of tabs in yaml files ### Patch Changes - [#46](#46) [`6f731ee`](6f731ee) Thanks [@mheob](https://github.com/mheob)! - Switch to typescript as source files - [#42](#42) [`cf8ba94`](cf8ba94) Thanks [@mheob](https://github.com/mheob)! - Format all files to the new tabs instead of spaces behaviour - [#36](#36) [`fd1474e`](fd1474e) Thanks [@mheob](https://github.com/mheob)! - Update dependencies ## 1.4.0 ### Minor Changes - 70cbb2c: Add typescript definitions ## 1.3.1 ### Patch Changes - 87fb7e0: Update all dependencies ## 1.3.0 ### Minor Changes - 347593b: Set markdown `printWidth` to `130`. ### Patch Changes - 347593b: Improve README to get a better copy/paste experience. ## 1.2.1 ### Patch Changes - 7d96f86: Update all dependencies ## 1.2.0 ### Minor Changes - ad1fc96: Add `prettier-plugin-jsdoc` to the prettier config. ## 1.1.0 ### Minor Changes - 76f0a62: Add some more rules like using tabs and some more. ## 1.0.0 ### Major Changes - 723ce7d: Initial configuration ## @mheob/tsconfig@2.1.0 # @mheob/tsconfig ## 2.0.0 ### Major Changes - remove depricated `importsNotUsedAsValues` config --> ([#121](#121)) by [@mheob](https://github.com/mheob) ## 1.0.1 ### Patch Changes - [#55](#55) [`27aa074`](27aa074) Thanks [@mheob](https://github.com/mheob)! - Simpplify and fix calling sub configurations ## 1.0.0 ### Major Changes - [#43](#43) [`c4e3768`](c4e3768) Thanks [@mheob](https://github.com/mheob)! - Initial Release ## Summary by CodeRabbit - **New Features** - Updated `@mheob/eslint-config` to version 6.0.0 with improved dependency management. - Updated `@mheob/prettier-config` to version 3.2.1 with the latest non-major dependencies. - Updated `@mheob/tsconfig` to version 2.1.0 with enhanced configurations. - **Chores** - Regular dependency updates to ensure compatibility and security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@trivago/prettier-plugin-sort-importsDescription
"Sorting/moving imports, object keys, class members, JSX keys, CSS properties or anything else ..." should not be part of
prettier. See: https://prettier.io/docs/en/rationale.html#what-prettier-is-_not_-concerned-aboutWe will add the possibility for sorting inputs in the ESLint config.