Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task view support for result backend lookup on event cache miss #772

Closed
wants to merge 1 commit into from

Conversation

johnarnold
Copy link
Contributor

This will allow looking up a task by id in the GUI even if the task is not in the event cache (due to flower restart or task cache size limit, etc)

E.g.
http://localhost:5555/task/07634992-5b5a-4228-b4c3-94bb184da2c5

Normally, you would just get a 'Unknown task' error. This way you can get at least partial results for debugging.

@johnarnold
Copy link
Contributor Author

johnarnold commented Jan 17, 2018

Related to #542

@jheld
Copy link
Contributor

jheld commented Jul 25, 2018

So as long as the return result of the task is currently still stored in the backend, then the idea is something should be able to be returned and shown by flower, in the event that flower no longer has its internal state for that task?

@johnarnold
Copy link
Contributor Author

@jheld yes that's the idea. I've tested it, it works. I'm still trying to get the "extended" task results into Celery, which will really make this useful.

@sonirico
Copy link

sonirico commented Jun 7, 2019

What's the state of this? It would be a nice feature to fallback to a persistent, scalable result backend after flower restarts.

@jheld
Copy link
Contributor

jheld commented Jul 9, 2019

This is a great addition. Can we please merge?

@jheld
Copy link
Contributor

jheld commented Jun 5, 2020

@johnarnold I haven't recently reviewed the blockers/failing checks (could be minor stuff). Do you have time in the next month to take a peek?

@mher
Copy link
Owner

mher commented Jun 26, 2020

Closing this pull request because it can cause many edge cases.

@mher mher closed this Jun 26, 2020
@phillipuniverse
Copy link

@mher what are the edge cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants