Added support for "QueueClassic" backend. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
mhfs
added a commit
that referenced
this pull request
Nov 23, 2012
Added support for "QueueClassic" backend.
|
Thank you very much. Could it be possible to have a version bump (eg. 2.0.4) so that I can update my Gemfile? |
|
You're welcome. 0.5.0 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find in this pull request a new QueueClassic backend for devise-async.
Since testing QueueClassic requires access to a real postgres database I used mocks instead.
The QC API is simple enough but to be sure I also validated my new adapter on my own rails application.
Please note: queue_classic does not listen to a placeholder queue like Resque, so you should be careful with the queue names. Out of the box devise-async and qc will not interact as they use different default queues. The user should either configure
Devise::Async.queue = 'default'or tellrake qc:workto listen onQUEUE=mailer.