Workaround for JRuby #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you please add a comment explaining the issue? Otherwise I'm pretty sure someone will change it back in the future. |
|
@unitymind Could you try to explain the issue? Otherwise I will close this PR as there has been no answer for some time now. |
|
At the moment of this fix JRuby implementation just fall back to NoMethodError on try(:devise_mailer) instead of nil. |
|
@unitymind Ok, thanks for the clarification. Is this not the case for current JRuby implementations anymore? To phrase it differently: is this still needed? |
|
I don't know, because reject Ruby in my work... It's bounded case for rare JRuby + defined custom mailer combination. |
|
@unitymind Ok. As nobody else seems to have this issue, are you Ok with closing it? |
|
Reject and close :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little fix for JRuby compatibility.