Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-56] Do not cache when cache is disable #58

Closed
wants to merge 2 commits into from
Closed

[ISSUE-56] Do not cache when cache is disable #58

wants to merge 2 commits into from

Conversation

jlurena
Copy link
Collaborator

@jlurena jlurena commented Jan 9, 2024 •
edited
Loading

Disable cache completely, do not use it when it is disabled.

Resolves #56

Spec run:
2024-01-09_17-21-12

@jlurena jlurena mentioned this pull request Jan 9, 2024
Closed
@jlurena
[ISSUE-56] Do not cache when cache is disable
9356b89 
Disable cache completely, do not use it when it is disabled.
mhgbrown
mhgbrown approved these changes Jan 11, 2024
View reviewed changes
Copy link
Owner

@mhgbrown mhgbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Feel free to merge whenever. I don't have an automated deploy setup yet, so I'll have to do it manually after you merge.

Separately, trying to figure out how to run the "Test" workflow on this branch, but I'm not seeing any "Workflow(s) awaiting approval" as mentioned here. Any ideas?

@jlurena
Copy link
Collaborator Author

jlurena commented Jan 11, 2024 •
edited
Loading

Looks great, thank you! Feel free to merge whenever. I don't have an automated deploy setup yet, so I'll have to do it manually after you merge.

Separately, trying to figure out how to run the "Test" workflow on this branch, but I'm not seeing any "Workflow(s) awaiting approval" as mentioned here. Any ideas?

I'm not sure honestly. Maybe workflow wasn't triggered? Also I don't have permissions to merge. Neither this one nor the other pull request I created.

Maybe permissions need updating? https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-scopes

@jlurena
Copy link
Collaborator Author

jlurena commented Jan 11, 2024

Closing in favor of #59

@jlurena jlurena closed this Jan 11, 2024
@jlurena jlurena deleted the ISSUE-56 branch January 11, 2024 17:26
@jlurena jlurena mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhgbrown mhgbrown mhgbrown approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If cache_resource is disabled, there should no writes to cache
2 participants
@jlurena @mhgbrown