Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-57] fix incompatability with rails/activesupport 4.x #60

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jlurena
Copy link
Collaborator

@jlurena jlurena commented Jan 12, 2024

Summary

Context: Continuation of #57
Adds specs for ActiveSupport and ActiveResource 4.x. Updates README to reflect changes.

Copy link
Owner

@mhgbrown mhgbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!


The following are limitations for ActiveResource/Rails versions

| ActiveSupport Version | Limitation |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice table!

@mhgbrown mhgbrown merged commit ef78bc5 into mhgbrown:master Jan 15, 2024
@mhgbrown
Copy link
Owner

And it passed! I'll cut a release tomorrow (16.01).

@jlurena jlurena deleted the ISSUE-57-fix-rails4x branch January 16, 2024 14:05
@mhgbrown
Copy link
Owner

ok I didn't make it today...I'll try again tomorrow

@mhgbrown
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants