Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested directory listing for archives without explicit directory names. #339

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix nested directory listing for archives without explicit directory names. #339

merged 1 commit into from
Jun 16, 2022

Conversation

jeremyje
Copy link
Contributor

Fixes #338

This PR fixes 2 issues:

  • Listing dot-prefixed directories had their '.' stripped.
  • Directory listing for nested directories were ignored.

This change adds some tests around this area.

@jeremyje jeremyje force-pushed the implicitdir branch 2 times, most recently from b9eb37f to e9e98de Compare June 15, 2022 15:53
@jeremyje jeremyje mentioned this pull request Jun 15, 2022
Closed
mholt
mholt requested changes Jun 15, 2022
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much for the added tests and the bug fixes. Just a couple questions/requests.

.gitignore Show resolved Hide resolved
fs_test.go Show resolved Hide resolved
fs_test.go Outdated Show resolved Hide resolved
@jeremyje jeremyje requested a review from mholt June 16, 2022 07:18
mholt
mholt approved these changes Jun 16, 2022
View reviewed changes
Copy link
Owner

@mholt mholt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for this PR. Let's start with this, and then figure out a fix for #340? Then we can enable that commented test at that time.

@mholt mholt merged commit b95d6b6 into mholt:master Jun 16, 2022
@jeremyje jeremyje deleted the implicitdir branch June 17, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArchiveFS.ReadDir does not list implicit directories in ZIP archives.
2 participants
@jeremyje @mholt