Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create archive to a continuous writing source file failed #388

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix create archive to a continuous writing source file failed #388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ad2b9
Fix create archive to a continuous writing source file failed
halfcrazy Sep 20, 2023
9898b73
Update archiver.go
mholt Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions archiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,14 @@ func openAndCopyFile(file File, w io.Writer) error {
return err
}
defer fileReader.Close()
_, err = io.Copy(w, fileReader)
return err
// When file is in use and size is being written to, creating the compressed
// file will fail with "archive/tar: write too long." Using CopyN gracefully
// handles this.
_, err = io.CopyN(w, fileReader, file.Size())
mholt marked this conversation as resolved.
Show resolved Hide resolved
if err != nil && err != io.EOF {
return err
}
return nil
}

// fileIsIncluded returns true if filename is included according to
Expand Down
Loading