Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22 by checking if file exists at destination before writing #89

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fixes #22 by checking if file exists at destination before writing #89

merged 2 commits into from
Nov 7, 2018

Conversation

johnarok
Copy link
Contributor

Thanks to @schollz for initial work

@johnarok
Copy link
Contributor Author

@weingart could you review this for me?

@mholt
Copy link
Owner

mholt commented Nov 7, 2018

File overwrite behavior is being improved (and made configurable) in #99, so I think this PR will be superseded.

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #99 supersedes this but essentially has a similar function, I will merge this now so that you're credited in the commit history; but will shortly be replacing the whole code base which implements an equivalent change.

@mholt mholt merged commit 5105dc1 into mholt:master Nov 7, 2018
mholt pushed a commit that referenced this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants