Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapview to leaflet #33

Merged
merged 63 commits into from
Jul 2, 2024
Merged

mapview to leaflet #33

merged 63 commits into from
Jul 2, 2024

Conversation

joyliujoyliu
Copy link

Fig 7 uses leaflet now, 2 legends, mouse-click popups with PI, detections, individuals, station name, detected by

@mhpob mhpob marked this pull request as draft July 2, 2024 13:37
@mhpob mhpob self-assigned this Jul 2, 2024
mhpob
mhpob requested changes Jul 2, 2024
View reviewed changes
Copy link
Owner

@mhpob mhpob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miscellaneous changes requested. After this, I will refactor to data.table

inst/qmd_template/make_tag_push_summary.qmd Outdated Show resolved Hide resolved
inst/qmd_template/make_tag_push_summary.qmd Outdated Show resolved Hide resolved
inst/qmd_template/make_tag_push_summary.qmd Outdated Show resolved Hide resolved
inst/qmd_template/make_tag_push_summary.qmd Outdated Show resolved Hide resolved
inst/qmd_template/make_tag_push_summary.qmd Show resolved Hide resolved
inst/qmd_template/make_tag_push_summary.qmd Outdated Show resolved Hide resolved
@mhpob mhpob changed the title my update mapview to leaflet Jul 2, 2024
joyliujoyliu
joyliujoyliu commented Jul 2, 2024
View reviewed changes
Copy link
Author

@joyliujoyliu joyliujoyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@joyliujoyliu joyliujoyliu marked this pull request as ready for review July 2, 2024 14:23
joyliujoyliu
joyliujoyliu commented Jul 2, 2024
View reviewed changes
Copy link
Author

@joyliujoyliu joyliujoyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

mhpob
mhpob reviewed Jul 2, 2024
View reviewed changes
Copy link
Owner

@mhpob mhpob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further changes requested.

inst/qmd_template/make_tag_push_summary.qmd Show resolved Hide resolved
R/leaflet_graph.R Outdated Show resolved Hide resolved
R/leaflet_graph.R Outdated Show resolved Hide resolved
@mhpob mhpob self-requested a review July 2, 2024 15:05
@mhpob mhpob changed the base branch from main to dev July 2, 2024 15:30
@joyliujoyliu joyliujoyliu merged commit 44285c5 into mhpob:dev Jul 2, 2024
6 checks passed
@joyliujoyliu
Copy link
Author

leaflet_graph.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhpob mhpob mhpob requested changes

Assignees

@mhpob mhpob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joyliujoyliu @mhpob