-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifting, delaying and resampling of streams #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For later use.
Start of making resamplebase more general.
This since it became clear that edge effects dominate the overall residuals, and one does just as well with a smaller shift kerner with the correct padding to ensure anything wrapped is ignored.
Also check that ShiftAndResample can mimic TimeDelay.
mhvk
force-pushed
the
time-delay-convolve
branch
2 times, most recently
from
July 18, 2021 00:36
b9cb272
to
0d11b7e
Compare
mhvk
force-pushed
the
time-delay-convolve
branch
from
July 18, 2021 00:45
0d11b7e
to
b996a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100 (except the most general case, of using a polyco, etc.)
Also improves the consistency of
Resample