Skip to content

Commit

Permalink
fix(web-components): update side nav CSS to ensure visibility of menu…
Browse files Browse the repository at this point in the history
… content is correct

Update side navigation CSS so that the visibility is handled by just the 'menu-visibility-visible'
class instead of in the media query, remove unused classes in ic-navigation-group CSS.

.#739
  • Loading branch information
GCHQ-Developer-847 committed Jul 18, 2023
1 parent 6679dca commit 630770d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,3 @@
left: var(--navigation-group-title-position-left);
white-space: nowrap;
}

.menu-visibility-visible {
visibility: visible;
}

.menu-visibility-hidden {
visibility: hidden;
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
flex-direction: column;
flex: 1 1 0;
overflow: auto;
visibility: hidden;
}

:host(.inline) .side-navigation-inner {
Expand All @@ -79,6 +78,10 @@
transition: left var(--ic-easing-transition-slow);
}

:host(.xs-menu-close) .side-navigation > * {
visibility: hidden;
}

:host(.anchor-right.xs-menu-open) .side-navigation {
right: 0;
left: auto;
Expand All @@ -99,7 +102,6 @@
background-color: var(--ic-theme-primary);
display: flex;
flex-direction: column;
visibility: hidden;
}

:host(.inline) .bottom-wrapper {
Expand Down Expand Up @@ -333,10 +335,7 @@ slot[name="app-icon"]::slotted(a) {

.menu-visibility-visible {
visibility: visible;
}

.menu-visibility-hidden {
visibility: hidden;
width: 100%;
}

/* Media Queries */
Expand Down Expand Up @@ -421,15 +420,6 @@ slot[name="app-icon"]::slotted(a) {
right: 0;
}

.side-navigation-inner {
width: 100%;
visibility: visible;
}

.bottom-wrapper {
visibility: visible;
}

.app-title-wrapper {
margin-left: 0;
border-left: none;
Expand Down

0 comments on commit 630770d

Please sign in to comment.