Merge branch 'master' into dependabot/npm_and_yarn/fastify-routes-3.0.1

.github/workflows/node.js.yml

@@ -0,0 +1,35 @@
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [10.x, 12.x, 14.x]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm i
+    - run: npm run build --if-present
+    - run: npm test
+    - run: npm run coverage
+
+    - name: Coveralls
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}

README.md

@@ -83,7 +83,7 @@ To works correctly, this library needs some specific environment variables:
 * `BACKOFFICE_HEADER_KEY`
 * `MICROSERVICE_GATEWAY_SERVICE_NAME`
 
-When creating a new service from Mia-Platform DevOps Console, they come already defined but you can always change or add them anytime as described [in the DevOps console documentation](https://docs.mia-platform.eu/development_suite/api-console/api-design/services#environment-variable-configuration).  
+When creating a new service from Mia-Platform DevOps Console, they come already defined but you can always change or add them anytime as described [in the DevOps console documentation](https://docs.mia-platform.eu/development_suite/api-console/api-design/services/#environment-variable-configuration).  
 In local, the environment variables are defined
 in this [file](examples/default.env).
 

tests/serviceBuilder.test.js

@@ -246,15 +246,20 @@ tap.test('serviceBuilder', test => {
     })
 
     innerTest.test('on TCP error rejects the promise', async assert => {
-      nock.enableNetConnect('unresolved-hostname-i-hope-so')
-      const service = serviceBuilder('unresolved-hostname-i-hope-so')
+      const myServiceNameScope = nock('http://unresolved-hostname')
+        .get('/foo')
+        .replyWithError({
+          code: 'ENOTFOUND',
+        })
+      const service = serviceBuilder('unresolved-hostname')
 
       try {
         await service.get('/foo')
         assert.fail('We can\'t reach this!')
       } catch (error) {
         assert.equal(error.code, 'ENOTFOUND')
       }
+      myServiceNameScope.done()
       assert.end()
     })
 
@@ -621,16 +626,20 @@ tap.test('serviceBuilder', test => {
     })
 
     innerTest.test('on TCP error rejects the promise', async assert => {
-      nock.enableNetConnect('unresolved-hostname-i-hope-so')
-
-      const service = serviceBuilder('unresolved-hostname-i-hope-so')
+      const myServiceNameScope = nock('http://unresolved-hostname')
+        .post('/foo')
+        .replyWithError({
+          code: 'ENOTFOUND',
+        })
+      const service = serviceBuilder('unresolved-hostname')
 
       try {
         await service.post('/foo', { the: 'sent body' }, {}, { returnAs: 'BUFFER' })
         assert.fail('We can\'t reach this!')
       } catch (error) {
         assert.equal(error.code, 'ENOTFOUND')
       }
+      myServiceNameScope.done()
       assert.end()
     })