Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging of default custom-plugin-lib schema with the user provided one #328

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Fix merging of default custom-plugin-lib schema with the user provided one #328

merged 9 commits into from
Feb 8, 2023

Conversation

giuliowaitforitdavide
Copy link
Contributor

@giuliowaitforitdavide giuliowaitforitdavide commented Jan 25, 2023 •
edited
Loading

Linked to #326

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Coverage Status

Coverage: 95.063% (+0.2%) from 94.882% when pulling e45d6fc on fix/schema-validation into be2fb0e on master.

@giuliowaitforitdavide giuliowaitforitdavide changed the title Fix merging of default custom-plugin-lin schema with the user provided one DRAFT: fix merging of default custom-plugin-lin schema with the user provided one Jan 25, 2023
@giuliowaitforitdavide giuliowaitforitdavide changed the title DRAFT: fix merging of default custom-plugin-lin schema with the user provided one WIP: fix merging of default custom-plugin-lin schema with the user provided one Jan 25, 2023
@giuliowaitforitdavide giuliowaitforitdavide changed the title WIP: fix merging of default custom-plugin-lin schema with the user provided one WIP: fix merging of default custom-plugin-lib schema with the user provided one Jan 25, 2023
@giuliowaitforitdavide giuliowaitforitdavide changed the title WIP: fix merging of default custom-plugin-lib schema with the user provided one Fix merging of default custom-plugin-lib schema with the user provided one Jan 26, 2023
@giuliowaitforitdavide giuliowaitforitdavide self-assigned this Jan 26, 2023
@giuliowaitforitdavide giuliowaitforitdavide added the bug Something isn't working label Jan 26, 2023
ghost
ghost reviewed Jan 26, 2023
View reviewed changes
tests/index.test.js Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jan 26, 2023

the log.out needs to be removed from the changes

ghost
ghost reviewed Jan 26, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@giuliowaitforitdavide
Copy link
Contributor Author

Removed log.out too

@giuliowaitforitdavide
Copy link
Contributor Author

Do I have to do something else? Or could we merge it?

fredmaggiowski
fredmaggiowski requested changes Jan 28, 2023
View reviewed changes
tests/index.test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/services/advanced-first-level-properties-service.js Outdated Show resolved Hide resolved
@fredmaggiowski
Copy link
Member

Also I'd like to hear from @davidebianchi on this one

@giuliowaitforitdavide
Copy link
Contributor Author

Still a bug

@fredmaggiowski
Copy link
Member

Still a bug

What do you mean @giuliowaitforitdavide ?

@fredmaggiowski fredmaggiowski merged commit 4305dcf into master Feb 8, 2023
@fredmaggiowski fredmaggiowski deleted the fix/schema-validation branch February 8, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

@ianFar96 ianFar96 ianFar96 approved these changes

@davidebianchi davidebianchi Awaiting requested review from davidebianchi

Assignees

@giuliowaitforitdavide giuliowaitforitdavide

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giuliowaitforitdavide @coveralls @fredmaggiowski @fabio-percivaldi @ianFar96