Fix RP 06 panel detection #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification uses the physical location of the reflectance panel from the actual drawings vs. approximate pixel coordinates - the inner 50% of the panel area is used for all subsequent calculations.
This change has been implemented for all panel versions.
Changed the transform to a homography.
Added 5 new panel images of the RP06 panel to the unit tests and two new unit tests, which test for correct identification of the panel and the correct raw values, i.e. mean, std, number of pixels and saturated. Also changed the unit tests to work with the RP<6 panels with the new methods.