Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reopen window after the result window is closed #227

Merged
merged 1 commit into from
May 6, 2023

Conversation

zhengpd
Copy link
Contributor

@zhengpd zhengpd commented May 6, 2023

Currently, if the display is set to TerminalWithCode and close the display window with C-w c, the window would not be reopened on running SnipRun next time.

This commit is for fixing it.

Currently, if the display is set to `TerminalWithCode` and close the
display window with `C-w c`, the window would not be reopened on running
`SnipRun` next time.

This commit is for fixing it.
@zhengpd zhengpd force-pushed the fix/window-close-and-reopen branch from 7f2efb5 to 21b7b04 Compare May 6, 2023 08:57
@michaelb
Copy link
Owner

michaelb commented May 6, 2023

Funnily enough, here if I close the TerminalWithCode view with C-w c, I don't have an issue and it reopens automatically. However, on C-w l then :q it remains closed, while it reopen with your fix. Thanks!

@michaelb michaelb merged commit bf01bdc into michaelb:master May 6, 2023
@zhengpd zhengpd deleted the fix/window-close-and-reopen branch May 6, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants