feat: more flexible terminal display options #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhance Sniprun configurations with following changes:
1. Allows to merge user options into default config_values key by key.
Consider below situation:
```lua
-- config_values
{ display_options = { terminal_width = 45, notification_timeout = 5 } }
-- user options
{ display_options = { terminal_scrollback = 1 } }
-- previous behavior result:
-- overrides display_options and lost default options
{ display_options = { terminal_scrollback = 1 } }
-- new behavior result:
-- merge into default options
{ display_options = { terminal_wdith = 45, notification_timeout = 5, terminal_scrollback = 1 } }
```
This is implemented with `vim.tbl_deep_extend("force", M.config_values, opts)`.
2. Sets local non-intrusive scrollback option in terminal buffer. Previous
implementation `set scrollback=1` changes scrollback globally, which
affects non-sniprun terminals.
3. Adds 3 new display options: `terminal_scrollback`,
`terminal_line_number` and `terminal_signcolumn`.
michaelb
reviewed
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhance Sniprun configurations with following changes:
This is implemented with
vim.tbl_deep_extend("force", M.config_values, opts).Sets local non-intrusive scrollback option in terminal buffer. Previous implementation
set scrollback=1changes scrollback globally, which affects non-sniprun terminals.Adds 3 new display options:
terminal_scrollback,terminal_line_numberandterminal_signcolumn.