Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.1 and build from source. #1

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

trzeciak
Copy link
Contributor

@trzeciak trzeciak commented Nov 9, 2020

See this issue: michaeleisel/zld#72

url "https://github.com/michaeleisel/zld/releases/download/#{version}/zld.zip"
sha256 "c606ec42d00b141576d2d2616ad3449a0ddca3edafd7917abdff063e919c8184"
url "https://github.com/michaeleisel/zld/archive/#{version}.zip"
sha256 "463faa979483a173d66c6204ce1289ddc05319ad70dfb0e685c1fbf9ca9ecd11"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the sha256 is now of the archive zip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, calculated like this:

wget https://github.com/michaeleisel/zld/archive/1.2.1.zip
sha256sum 1.2.1.zip
# 463faa979483a173d66c6204ce1289ddc05319ad70dfb0e685c1fbf9ca9ecd11  1.2.1.zip

@michaeleisel
Copy link
Owner

thinking more about this, my one concern is of updating it every release. right now, the "releases" page of zld is the source of truth on what the latest release is, but now we have to sync this one up as well. maybe people really like using brew to install though? i'm not sure

@trzeciak
Copy link
Contributor Author

trzeciak commented Nov 9, 2020

yea, if it will be required on every releases them yes it's poor xD
if it doesn't bother you, I can update it a few more times,
maybe in future we automate it and weave it to release process?
and yes, eg me I like use brew to install other development software

@trzeciak
Copy link
Contributor Author

trzeciak commented Nov 9, 2020

but in the other hand, this tool (zld) should be synchronised with Xcode version and a brew allows to install only a latest version of software(?)

@michaeleisel michaeleisel merged commit 51446ff into michaeleisel:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants