Fix a couple of issues #2
Conversation
|
Thanks a lot! I'll look into this as soon as I'm back from the mountains 😀 |
|
Hi, am a developer myself. If I can do anything to help please let me know. |
|
Uh, oh... plietar just applied a bunch of changes to librespot which break spotty. I'll have to do some more work, soon. |
|
I've started a new dev branch using librespot's latest code. I had to manually port your changes, as the base code has changed too much. Feel free to check it out: e245006 |
| @@ -264,8 +266,10 @@ impl Future for Main { | |||
| progress = true; | |||
| } | |||
| } | |||
|
|
|||
| if let Async::Ready(session) = self.connect.poll().unwrap() { | |||
There was a problem hiding this comment.
This part of this pull request actually breaks the dev branch. Did you check it out? It implements the latest of plietar's changes.
|
This PR should still be merged, it resolves #6. |
|
I'm reluctant to merge as my comment is still true (patch breaks newer code), and #6 while ugly doesn't break functionality. Credentials would be verified/saved despite the error message. |
|
I understand. If I isolate the code that fixes the error and submit a seperate PR, would you merge? |
|
The librespot code has seen so many changes, this pull request is rather useless. Please submit a new pull request, should you see need. Thanks! |
Okay, I'm not a rust developer either, but I think I've fixed a couple of crashes I've seen whilst trying to get this to run on FreeBSD. I've not yet managed to make it work successfully, but this feels like an improvement so I thought I'd share:
The connect loop seems to poll the future every time, even if it's already complete. This was causing a crash for me.
The get credentials code was calling unwrap() without checking for an error. I think I've fixed that too (although I always get an error, so I might have broken the success case).