Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard avoiding not working properly on Collection Views #80

Merged
merged 2 commits into from
Mar 4, 2014

Conversation

jamztang
Copy link

@jamztang jamztang commented Jan 9, 2014

There's an infinite scrolling bug when using TPKeyboardAvoiding with UICollectionView.

keyboard-avoid

Notice the scrollbar keeps shrinking and you can never scroll to the bottom.

It's caused by repetitive calling setContentSize: while scrolling, which doesn't happen in UITableView or UIScrollView.

The fix is to prevent setting the same value when the contentSize is already properly configured.

pod ‘TPKeyboardAvoiding’, :git => ‘https://github.com/jamztang/TPKeyboardAvoiding.git’, :branch => ‘bug/infinite-scrolling’

michaeltyson added a commit that referenced this pull request Mar 4, 2014
Keyboard avoiding not working properly on Collection Views
@michaeltyson michaeltyson merged commit b8439a7 into michaeltyson:master Mar 4, 2014
@michaeltyson
Copy link
Owner

Thanks for this! Sorry about the delay getting to it =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants