Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement some of the gl-matrix methods #36

Open
stasm opened this issue Aug 26, 2017 · 3 comments
Open

Reimplement some of the gl-matrix methods #36

stasm opened this issue Aug 26, 2017 · 3 comments

Comments

@stasm
Copy link
Collaborator

stasm commented Aug 26, 2017

For instance, mat4.create could be implemented as:

return Float32Array.of(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1);
@stasm
Copy link
Collaborator Author

stasm commented Aug 27, 2017

There are also quite a few bytes that we could shave off by making our own methods return results instead of writing to the first argument. Once the core code stabilizes I'll make an inventory of the methods we use and I'll try to reimplement them.

@michalbe
Copy link
Owner

@stasm is this still a valid issue? We've tried that last week, without any reasonable lean boost.

@stasm
Copy link
Collaborator Author

stasm commented Sep 16, 2017

Rolling a custom implementation of matrix math is a big task. gl-matrix does the job well and has a better testing coverage. I vote close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants