Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the support for coarse location #207

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Conversation

michalchudziak
Copy link
Owner

@michalchudziak michalchudziak commented Oct 20, 2022

Overview

Fixes: #205
Fixes: #206

Migrated to getLastLocation from Fused Provider. In case the location is not cached on the device we do a single update request using the location updates API.

Fixed issue with null context being passed to the FusedLocationProvider

Test Plan

  • Invoke getCurrentLocation()
  • Use the approximate location
  • Check the results

@@ -37,7 +37,7 @@ export default function WatchPositionExample() {
const [position, setPosition] = useState<string | null>(null);
const [subscriptionId, setSubscriptionId] = useState<number | null>(null);
useEffect(() => {
watchPosition();
// watchPosition();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

@michalchudziak michalchudziak merged commit 362bf80 into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants