Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Batch and Segment input #70

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Added Batch and Segment input #70

merged 4 commits into from
Jun 25, 2020

Conversation

RelativeForce
Copy link
Collaborator

@RelativeForce RelativeForce commented Jun 25, 2020 •
edited
Loading

Issues

closes #53
closes #51

Summary of changes

  • Added BatchInput component which contains the input for the 'number of batches' and the 'number of segments per batch'. Error reporting occurs as the data is changed as parsing String into an Int is cheap.
  • Deleted clearPlotBatchId as it was unused
  • Added the batchCount and segmentCount to the State
  • Refactored redrawWithBounds into redraw as has the same functionality as a redraw function the only difference is that it also updates the bounds in the state.
  • Added the batchCount as a parameter for the JobBatcher
  • Added segmentCount as a parameter for the RobustPlot plot command
  • Removed batchSegmentCount and segmentCount constants as they're unused

Tests

  • Test.Plot.JobBatcher.AddPlot (Fixed)

@RelativeForce RelativeForce added the enhancement New feature or request label Jun 25, 2020
@RelativeForce RelativeForce self-assigned this Jun 25, 2020
@RelativeForce RelativeForce marked this pull request as ready for review June 25, 2020 12:38
This was referenced Jun 25, 2020
Closed
Closed
@RelativeForce RelativeForce merged commit 094bbda into master Jun 25, 2020
@RelativeForce RelativeForce deleted the batch-input branch June 25, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkonecny michalkonecny michalkonecny approved these changes

Assignees

@RelativeForce RelativeForce

Labels
enhancement New feature or request
Projects
None yet
Milestone
M3 (Async plotting of box enclosure)
Development

Successfully merging this pull request may close these issues.

Add batch size user input Add line segmentation user input
2 participants
@RelativeForce @michalkonecny