Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zoom while calculating border limit #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sliterok
Copy link
Contributor

I guess it would break backwards-compatibility if user has already fixed zoom himself somehow :) resolves #16, resolves #12.

I guess it would break backwards-compatibility if user has already fixed zoom himself somehow :) resolves michaschwab#16, resolves michaschwab#12.
@michaschwab
Copy link
Owner

Thanks for your PR! Could you please be more specific about what problem you're trying to solve here and how?
Also, do you mind adding semicolons and not using combined let statements?
Thanks!

Added semicolons, removed combined let statements
@sliterok
Copy link
Contributor Author

sliterok commented Nov 4, 2020

If you have bounds option it doesn't take the zoom into account when calculating the limit of how far you can pan.
Made demonstration here: https://jsfiddle.net/z1nsh79o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounds only respects initial zoom Update bounds on the fly
2 participants