Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/commit tag - bug fixes #9

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Ft/commit tag - bug fixes #9

merged 3 commits into from
Jan 19, 2021

Conversation

michmich112
Copy link
Owner

Bug fixes for problems that were found during manual testing in the GitHub actions environment

  • Tags were not pushing -> added the -u flag to promote upstream (tests succeeded after that)
  • Tags were not being created properly due to missing message -> set default message to be the new version number
  • Inconsistent error stream, changed it to warnings (push action is successful but posts to stderr even with return code 0)

@michmich112
git commands to push tags
8f061a9 
Signed-off-by: michmich112 <cantacuzene.michel@gmail.com>
@michmich112
test with console log and warnings
c1ef17c 
Signed-off-by: michmich112 <cantacuzene.michel@gmail.com>
@michmich112
remove un-necessary console logs
bd242d0 
Signed-off-by: michmich112 <cantacuzene.michel@gmail.com>
@michmich112 michmich112 added the bug Something isn't working label Jan 19, 2021
@michmich112 michmich112 merged commit 9db70f2 into develop Jan 19, 2021
@michmich112 michmich112 deleted the ft/commit_tag branch March 6, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebTalbot SebTalbot SebTalbot approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michmich112 @SebTalbot