Escape " in paths on non-Win platforms #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it works you can update your original PR with this change, because I am not sure if It will count you as a contributor If I merge this PR. 😨 |
|
I am still figuring it out how to get this change as a "local extension" so
I can actually test it.
It's okay if you change the code directly if you prefer to. I'll read how
to install the extension locally here anyway ;)
…On Tue, Mar 5, 2019 at 11:02 AM mickeypearce ***@***.***> wrote:
If it works you can update your original PR with this change, because I am
not sure if It will count you as a contributor If I merge this PR. 😨
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQe14gGujcghLChcsZ6IPBBpXFrch55lks5vTr9KgaJpZM4bfPtL>
.
|
Merged
|
Usually you run |
|
Solved in #11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafael-trevisan , I cannot push to your fork so this is a continutation of #9 .
I did a replace of " with escaped " as you suggested for non-Win platform. I will be delighted if you could test. :)