Ref #8286. Join RTOS tutorials #149

pablogs9 · 2020-04-27T16:35:45Z

This PR removes FreeRTOS and Zephyr specific tutorials and merge them all into First micro-ROS Application on an RTOS

_docs/tutorials/core/first_application_rtos/index.md

FranFin · 2020-04-28T05:53:12Z

_docs/tutorials/core/first_application_rtos/index.md

+![pingpong](http://www.plantuml.com/plantuml/png/ZOwnIWGn48RxFCNFzSkoUG2vqce5jHEHi1dtWZkPa6GByNntavZY10yknMJu-ORlFwPiOjvvK-d3-M2YOR1uMKvHc93ZJafvoMML07d7h1NAE-DPWblg_na8vnwEx9OeZmzFOt1-BK7AzetJciPxCfRYVw1S0SbRLBEg1IpXPIvpUWLCmZpXIm6BS3addt7uQpu0ZQlxT1MK2r0g-7sfqbsbRrVfMrMwgbev3CDTlsqJGtJhATUmSMrMg5TKwaZUxfcttuMt7m00)
+
+The files contained in a micro-ROS app is slightly RTOS specific. The following table aims to clarify which files are required for creating a new app:
+


Maybe here in the 'File' column you could specify the path as well, since as I can remember these files do not go all into the same folder.
Also, I remember that before you were creating a folder named my_brand_new_app, I liked that flow of the tutorial since it was taking the user by hand and explaining step by step what he should do. I think we should follow the same line of action, with the only difference that now the text that goes into the files is reference and not directly in the tutorial.

Please check the new approach

_docs/tutorials/core/first_application_rtos/index.md

ralph-lange · 2020-04-28T06:10:49Z

_docs/tutorials/core/first_application_rtos/index.md

+
+## Installing the micro-ROS build system
+
+First of all, make sure that you have a **ROS 2** installation in the computer. On the **ROS 2** installation open a command line and follow these steps:


I assume that the following section can be shortened even more. We agreed to build this tutorial on top of the 'First micro-ROS application on Linux tutorial', i.e. we assume that the reader already completed the Linux-based tutorial and thus has ROS2 and micro-ROS installed, knows the ping-pong application an so on.
I propose to add a prominent note on this assumption here. See also my overview at https://micro-ros.github.io/docs/tutorials/core/overview/

Please check the new approach. Maybe the four-step workflow explanation can be also removed, let me know if so.

_docs/tutorials/core/first_application_rtos/index.md

FranFin · 2020-04-28T08:04:08Z

_docs/tutorials/core/first_application_rtos/index.md

+cd uros_pingpong
+touch Kconfig
+touch Makefile
+touch uros_pingpong_main.c


Suggested change

touch uros_pingpong_main.c

touch app.c

_docs/tutorials/core/first_application_rtos/index.md

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Co-Authored-By: Ralph Lange <ralph-lange@users.noreply.github.com>

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

ralph-lange

Very good work. The integration of the three RTOS is very good. I've only few small change requests.

_docs/tutorials/core/first_application_rtos/index.md

ralph-lange · 2020-05-08T10:17:46Z

_docs/tutorials/core/first_application_rtos/index.md

+    <td rowspan="4">Nuttx</td>
+    <td >app.c</td>
+    <td >micro-ROS app code.</td>
+    <td rowspan="4"><a href="https://github.com/micro-ROS/apps/tree/dashing/examples/uros_pingpong">Sample app</a></td>


Link does not work.

_docs/tutorials/core/first_application_rtos/index.md

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

pablogs9 requested review from ralph-lange, julionce and FranFin April 27, 2020 16:35

pablogs9 changed the title ~~Feature/join rtos tutorials~~ Join RTOS tutorials Apr 27, 2020

ralph-lange mentioned this pull request Apr 27, 2020

Restructuring of tutorials #143

Closed

42 tasks

FranFin suggested changes Apr 28, 2020

View reviewed changes

ralph-lange requested changes Apr 28, 2020

View reviewed changes

pablogs9 requested review from ralph-lange and FranFin April 28, 2020 07:34

FranFin suggested changes Apr 28, 2020

View reviewed changes

pablogs9 changed the title ~~Join RTOS tutorials~~ Ref # 8286. Join RTOS tutorials Apr 28, 2020

pablogs9 changed the title ~~Ref # 8286. Join RTOS tutorials~~ Ref #8286. Join RTOS tutorials Apr 28, 2020

FranFin suggested changes Apr 30, 2020

View reviewed changes

pablogs9 requested a review from FranFin April 30, 2020 13:11

pablogs9 assigned FranFin Apr 30, 2020

FranFin mentioned this pull request Apr 30, 2020

Ref #8285. Updates on micro-ROS Linux #150

Merged

FranFin previously approved these changes Apr 30, 2020

View reviewed changes

pablogs9 dismissed FranFin’s stale review via 5dc4bb8 May 4, 2020 07:15

pablogs9 mentioned this pull request May 4, 2020

First micro-ROS Application on an RTOS: make menuconfig fails #157

Closed

pablogs9 and others added 11 commits May 6, 2020 15:20

Refactor getting started with RTOS

717378a

Removed FreeRTOS and Zephyr specific tutorials

35bdce7

Update Nuttx

1073b2f

Update _docs/tutorials/core/first_application_rtos/index.md

5e03f32

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

d4cbc75

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

2d68189

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

2bd34bf

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

9642db0

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

7ee85e2

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

55e983d

Co-Authored-By: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

b3705ad

Co-Authored-By: Ralph Lange <ralph-lange@users.noreply.github.com>

pablogs9 and others added 13 commits May 6, 2020 15:20

Update _docs/tutorials/core/first_application_rtos/index.md

b522b7e

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

58d14d4

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

91999f7

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

eae168e

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

259f853

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

5016c12

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

aca6fda

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

5078ba9

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

f48338c

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

32decb0

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

1c137d6

Co-authored-by: FranFin <58737168+FranFin@users.noreply.github.com>

Updated kconfig-frontends installation

6d4dee8

Update cf

d586b19

pablogs9 force-pushed the feature/join_RTOS_tutorials branch from 5dc4bb8 to d586b19 Compare May 6, 2020 13:20

ralph-lange requested changes May 8, 2020

View reviewed changes

pablogs9 and others added 11 commits May 11, 2020 08:17

Update _docs/tutorials/core/first_application_rtos/index.md

58fb545

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

de36fe2

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

b1b67f5

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

534ce55

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

8f1e90f

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

854c509

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

e26e64c

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

b02bacf

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

7f847a9

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

2ce6c4f

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

Update _docs/tutorials/core/first_application_rtos/index.md

b95dc6a

Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>

ralph-lange approved these changes May 20, 2020

View reviewed changes

ralph-lange marked this pull request as ready for review May 20, 2020 07:06

ralph-lange merged commit 5d758c5 into master May 20, 2020

ralph-lange deleted the feature/join_RTOS_tutorials branch June 3, 2020 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ref #8286. Join RTOS tutorials #149

Ref #8286. Join RTOS tutorials #149

pablogs9 commented Apr 27, 2020

FranFin Apr 28, 2020

pablogs9 Apr 28, 2020

ralph-lange Apr 28, 2020

pablogs9 Apr 28, 2020

FranFin Apr 28, 2020

ralph-lange left a comment

ralph-lange May 8, 2020

		![pingpong](http://www.plantuml.com/plantuml/png/ZOwnIWGn48RxFCNFzSkoUG2vqce5jHEHi1dtWZkPa6GByNntavZY10yknMJu-ORlFwPiOjvvK-d3-M2YOR1uMKvHc93ZJafvoMML07d7h1NAE-DPWblg_na8vnwEx9OeZmzFOt1-BK7AzetJciPxCfRYVw1S0SbRLBEg1IpXPIvpUWLCmZpXIm6BS3addt7uQpu0ZQlxT1MK2r0g-7sfqbsbRrVfMrMwgbev3CDTlsqJGtJhATUmSMrMg5TKwaZUxfcttuMt7m00)

		The files contained in a micro-ROS app is slightly RTOS specific. The following table aims to clarify which files are required for creating a new app:


		## Installing the micro-ROS build system

		First of all, make sure that you have a ROS 2 installation in the computer. On the ROS 2 installation open a command line and follow these steps:

Ref #8286. Join RTOS tutorials #149

Ref #8286. Join RTOS tutorials #149

Conversation

pablogs9 commented Apr 27, 2020

FranFin Apr 28, 2020

Choose a reason for hiding this comment

pablogs9 Apr 28, 2020

Choose a reason for hiding this comment

ralph-lange Apr 28, 2020

Choose a reason for hiding this comment

pablogs9 Apr 28, 2020

Choose a reason for hiding this comment

FranFin Apr 28, 2020

Choose a reason for hiding this comment

ralph-lange left a comment

Choose a reason for hiding this comment

ralph-lange May 8, 2020

Choose a reason for hiding this comment