Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move topic name to topic object #240

Draft
wants to merge 6 commits into
base: rolling
Choose a base branch
from
Draft

Conversation

pablogs9
Copy link
Member

No description provided.

@pablogs9 pablogs9 closed this Mar 25, 2022
@pablogs9 pablogs9 reopened this Mar 25, 2022
@github-actions
Copy link

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 120 B
Service 4 248 B
Client 4 248 B
Subscription 4 216 B
Publisher 4 224 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34244 B

@pablogs9
Copy link
Member Author

@mergify backport foxy galactic

@pablogs9 pablogs9 marked this pull request as draft March 25, 2022 11:05
@github-actions
Copy link

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Service 4 256 B
Client 4 256 B
Subscription 4 288 B
Publisher 4 296 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34400 B

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #240 (959ccf1) into main (644c574) will increase coverage by 0.52%.
The diff coverage is 77.77%.

❗ Current head 959ccf1 differs from pull request most recent head 732a8d1. Consider uploading reports for the commit 732a8d1 to get more accurate results

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   49.50%   50.02%   +0.52%     
==========================================
  Files          44       43       -1     
  Lines        1709     1673      -36     
  Branches      484      469      -15     
==========================================
- Hits          846      837       -9     
+ Misses        640      619      -21     
+ Partials      223      217       -6     
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/callbacks.c 65.57% <ø> (ø)
rmw_microxrcedds_c/src/rmw_init.c 58.06% <ø> (-0.27%) ⬇️
rmw_microxrcedds_c/src/types.c 69.74% <ø> (-0.18%) ⬇️
rmw_microxrcedds_c/src/rmw_client.c 49.10% <60.00%> (-0.46%) ⬇️
rmw_microxrcedds_c/src/rmw_service.c 48.67% <60.00%> (-0.46%) ⬇️
rmw_microxrcedds_c/src/rmw_publisher.c 53.14% <78.57%> (+5.05%) ⬆️
rmw_microxrcedds_c/src/rmw_subscription.c 57.33% <78.57%> (+4.04%) ⬆️
rmw_microxrcedds_c/src/rmw_publish.c 45.45% <100.00%> (ø)
rmw_microxrcedds_c/src/rmw_request.c 75.51% <100.00%> (ø)
rmw_microxrcedds_c/src/rmw_response.c 75.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644c574...732a8d1. Read the comment docs.

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@github-actions
Copy link

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Service 4 256 B
Client 4 256 B
Subscription 4 288 B
Publisher 4 296 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34400 B

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

backport foxy galactic

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants