Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout for no metadata run session #305

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

Conversation

Acuadros95
Copy link
Contributor

Spin is not waiting if a session only haves timers, ending in a 100% CPU usage with code like this one: int32_publisher.

Also, we should run all sessions atleast once, to ensure a response to incoming data (From Hard liveliness check for example).

Related issue: #297

Signed-off-by: acuadros95 <acuadros1995@gmail.com>
@Acuadros95 Acuadros95 requested a review from pablogs9 July 25, 2023 13:42
Signed-off-by: acuadros95 <acuadros1995@gmail.com>
Signed-off-by: acuadros95 <acuadros1995@gmail.com>
@github-actions
Copy link

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 280 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34500 B

@Acuadros95
Copy link
Contributor Author

@mergify backport humble iron

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

backport humble iron

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@Acuadros95 Acuadros95 changed the title Run session if any session is present Fix timeout for no metadata run session Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant